Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

fix the issue #351 #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LilyEvansHogwarts
Copy link

I fix the bug of num_cores parameter.

@LilyEvansHogwarts
Copy link
Author

I read methods/bayesian_optimization.py and find the objective is defined as self.objective = SingleObjective(self.f, self.batch_size, self.funct_name). And I believe it should be changed into self.objective = SingleObjective(self.f, self.num_cores, self.funct_name). Otherwise, the num_cores parameter would be useless.

@LilyEvansHogwarts
Copy link
Author

The original code in methods/bayesian_optimization.py
self.objective = SingleObjective(self.f, self.batch_size,self.objective_name)
I believe the code should be changed into:
self.objective = SingleObjective(self.f, self.num_cores,self.objective_name)

@LilyEvansHogwarts
Copy link
Author

@apaleyes @lawrennd

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #352 (f184bad) into master (0be0508) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   77.44%   77.08%   -0.37%     
==========================================
  Files          97       97              
  Lines        4678     4678              
==========================================
- Hits         3623     3606      -17     
- Misses       1055     1072      +17     
Impacted Files Coverage Δ
GPyOpt/methods/bayesian_optimization.py 88.88% <100.00%> (ø)
GPyOpt/core/task/objective.py 57.69% <0.00%> (-28.85%) ⬇️
GPyOpt/util/general.py 44.35% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be0508...f184bad. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants